Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some substrate dependencies to improve compile time #194

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Dec 2, 2020

Removes some big substrate dependencies which were only being used for one or two types. I have just copied these over verbatim, which is acceptable since we are targeting a specific version of substrate at the moment.

This shaves about a minute off the compile time, down from 3:42 to 2:46 on my machine.

@ascjones ascjones requested a review from dvdplm December 2, 2020 16:48
@ascjones ascjones changed the title Define some local types to remove dependencies and improve compile time Remove some substrate dependencies to improve compile time Dec 2, 2020
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the speedup is real! Left a few nitpicks.

src/rpc.rs Show resolved Hide resolved
src/rpc.rs Show resolved Hide resolved
@ascjones ascjones merged commit 0b3c8d4 into master Dec 3, 2020
@ascjones ascjones deleted the aj-faster-build branch December 3, 2020 13:20
@ascjones ascjones mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants