-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event Phase::Initialization #215
Conversation
c558350
to
22d544c
Compare
The build is failed due to an upstream compiling issue paritytech/substrate#7844 |
Could we rerun the CI? |
Funny thing, we run into libp2p/rust-libp2p#1912 now :( |
@niklasad1 would bumping to |
Yes if it would be a direct dependency but unfortunately, in this case, it's fetched via sc-network which depends on an old version of libp2p so we are blocked until a new release :( Still, I think it's fine the merge this PR anyway |
@niklasad1 (@dvdplm) who makes the final call on this? |
I think it is up to @ascjones :) However, the fix is being backported to parity-multiaddr 0.9 so let's wait for it, |
This is introduced since paritytech/substrate@2c87fe1
https://github.com/paritytech/substrate/blob/fa404167bbfe7bfd459689d25fc19b86da698367/frame/system/src/lib.rs#L278-L285