Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonrpsee #317

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Update jsonrpsee #317

merged 1 commit into from
Nov 11, 2021

Conversation

ascjones
Copy link
Contributor

No description provided.

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

we should check that the URLs contains the port number because default port numbers are not assigned by the WS client anymore FWIW.

@ascjones
Copy link
Contributor Author

we should check that the URLs contains the port number because default port numbers are not assigned by the WS client anymore FWIW.

Our default URL contains the port:

let url = self.url.as_deref().unwrap_or("ws://127.0.0.1:9944");
.

I assume if the user supplies a URL without the port then RpcClient::try_from_url(url) will fail?

@niklasad1
Copy link
Member

niklasad1 commented Nov 11, 2021

I assume if the user supplies a URL without the port then RpcClient::try_from_url(url) will fail?

Exactly, but it will throw an error with bad URL quite clearly but it's probably worth document somewhere I guess.

@ascjones ascjones merged commit a170a57 into master Nov 11, 2021
@ascjones ascjones deleted the aj-update-jsonrpsee branch November 11, 2021 15:43
sander2 added a commit to interlay/subxt that referenced this pull request Nov 29, 2021
0623forbidden pushed a commit to DEIPworld/substrate-subxt that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants