codegen: fix compact unnamed fields #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Nov 24, 2021
insipx
approved these changes
Nov 24, 2021
jsdw
approved these changes
Nov 25, 2021
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* codegen: fix compact unnamed fields * Fmt * Regenerate polkadot codegen example. * Ignore clippy for generated code * Limit the number of test threads * Revert "Limit the number of test threads" This reverts commit f1947dc. * Delete duplicate node_runtime metadata * Update node_runtime metadata * Update balances events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated types for unnamed fields were not preserving the
#[code(compact)]attribute e.g.struct TupleStruct(#[codec(compact)] u32);There is still a bit of code duplication here which was a cause of this bug (it works for named fields), it needs consolidating. Will do a follow up with refactoring.