Decode raw events using scale_value and return the decoded Values, too #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the decode logic and rely on scale-value instead. Since that returns Value types which are more descriptive than just the event bytes, we forward those on in the RawEventDetails.
There will be a small hit to performance as a result of using scale_value's decode, since it doesn't just throw the bytes away but instead builds and returns Value types. I think the tradeoff of not having to have duplicate decode logic (and the scale_value decode stuff I think does the best job so far of catering for edge cases and bitvec handling and such) is worth it though.
Closes #572, #570