Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make verbose rpc error display #758

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

techraed
Copy link
Contributor

Just a small PR with changes very need for my tiny tool.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Dec 26, 2022

User @SabaunT, please sign the CLA here.

@techraed
Copy link
Contributor Author

@jsdw @niklasad1 hey guys, can I ask you for a quick review?

subxt/src/error.rs Outdated Show resolved Hide resolved
subxt/src/error.rs Outdated Show resolved Hide resolved
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@techraed techraed requested review from jsdw and niklasad1 and removed request for jsdw and niklasad1 January 9, 2023 13:40
@Xanewok
Copy link
Contributor

Xanewok commented Jan 9, 2023

This is miniscule and improves error display, so I'm merging this.

@Xanewok Xanewok merged commit d41f657 into paritytech:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants