Replace axios with fetch in utils package (#850)

paritytech · Mar 27, 2023 · dde62dd · dde62dd
1 parent c27263d
commit dde62dd
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 22 deletions.
diff --git a/javascript/package-lock.json b/javascript/package-lock.json
diff --git a/javascript/packages/cli/package.json b/javascript/packages/cli/package.json
@@ -54,7 +54,7 @@
   "dependencies": {
     "@zombienet/dsl-parser-wrapper": "^0.1.7",
     "@zombienet/orchestrator": "^0.0.33",
-    "@zombienet/utils": "^0.0.17",
+    "@zombienet/utils": "^0.0.18",
     "axios": "^0.27.2",
     "commander": "^10.0.0",
     "debug": "^4.3.2",

diff --git a/javascript/packages/orchestrator/package.json b/javascript/packages/orchestrator/package.json
@@ -36,7 +36,7 @@
     "@polkadot/api": "^10.2.1",
     "@polkadot/keyring": "^11.1.1",
     "@polkadot/util-crypto": "^11.1.1",
-    "@zombienet/utils": "^0.0.17",
+    "@zombienet/utils": "^0.0.18",
     "axios": "^0.27.2",
     "chai": "^4.3.7",
     "debug": "^4.3.2",

diff --git a/javascript/packages/utils/package.json b/javascript/packages/utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@zombienet/utils",
-  "version": "0.0.17",
+  "version": "0.0.18",
   "description": "Useful utilities for ZombieNet Framework",
   "main": "dist/index.js",
   "author": "Parity Technologies <admin@parity.io>",
@@ -27,7 +27,6 @@
   },
   "types": "./dist/index.d.ts",
   "dependencies": {
-    "axios": "^0.27.2",
     "cli-table3": "^0.6.2",
     "debug": "^4.3.2",
     "nunjucks": "^3.2.3",

diff --git a/javascript/packages/utils/src/net.ts b/javascript/packages/utils/src/net.ts
@@ -1,4 +1,3 @@
-import axios from "axios";
 import dns from "dns";
 import fs from "fs";
 import { AddressInfo, createServer } from "net";
@@ -36,17 +35,18 @@ export async function getHostIp(): Promise<string> {
 export async function downloadFile(url: string, dest: string): Promise<void> {
   try {
     await new Promise<void>(async (resolve) => {
-      const { data } = await axios({
-        url,
-        method: "GET",
-        responseType: "stream",
-      });
-
+      const response = await fetch(url);
+      const reader = response.body?.getReader();
       const writer = fs.createWriteStream(dest);
-      data.pipe(writer);
-      data.on("end", () => {
-        resolve();
-      });
+      while (true) {
+        const read = await reader?.read();
+        if (read?.done) {
+          writer.close();
+          resolve();
+          break;
+        }
+        writer.write(read?.value);
+      }
     });
   } catch (err) {
     console.log(