Fixes for no leaking resources in k8s (#923)

* fix permissions for delete cron * don't let the network up on test/s fail
paritytech · Apr 11, 2023 · df85916 · df85916
1 parent 1de1847
commit df85916
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 28 deletions.
diff --git a/javascript/packages/orchestrator/src/test-runner/index.ts b/javascript/packages/orchestrator/src/test-runner/index.ts
@@ -138,34 +138,12 @@ export async function run(
           console.log(
             `\n\n\t${decorators.red("❌ One or more of your test failed...")}`,
           );
-
-          switch (network.client.providerName) {
-            case "podman":
-            case "native":
-              console.log(`\n\t ${decorators.green("Deleting network")}`);
-              await network.stop();
-              break;
-            case "kubernetes":
-              if (inCI) {
-                // keep pods running for 30 mins.
-                console.log(
-                  `\n\t${decorators.red(
-                    "One or more test failed, we will keep the namespace up for 30 more minutes",
-                  )}`,
-                );
-                await network.upsertCronJob(30);
-              } else {
-                console.log(`\n\t ${decorators.green("Deleting network")}`);
-                await network.stop();
-              }
-              break;
-          }
-        } else {
-          // All test passed, just remove the network
-          console.log(`\n\t ${decorators.green("Deleting network")}`);
-          await network.stop();
         }
 
+        // All test passed, just remove the network
+        console.log(`\n\t ${decorators.green("Deleting network")}`);
+        await network.stop();
+
         // show logs
         console.log(
           `\n\n\t${decorators.magenta(

diff --git a/javascript/packages/orchestrator/static-configs/job-svc-account.yaml b/javascript/packages/orchestrator/static-configs/job-svc-account.yaml
@@ -25,14 +25,14 @@ roleRef:
   apiGroup: rbac.authorization.k8s.io
 ---
 apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRoleBinding
+kind: RoleBinding
 metadata:
   name: delete-podmonitor-to-sa
 subjects:
   - kind: ServiceAccount
     name: zombie-internal-kubectl
     namespace: "{{namespace}}"
 roleRef:
-  kind: ClusterRole
+  kind: Role
   name: delete-podmonitors
   apiGroup: rbac.authorization.k8s.io