New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter the parser and introduce new rule #1066

Merged

wirednkod merged 14 commits into main from nik-substracting-metrics

May 19, 2023

Contributor

wirednkod commented May 17, 2023

Fixes #1044

wirednkod added 5 commits

May 18, 2023 01:08


          Alter the parser and introduce new rule

e5b9224


          Alter parser's rust code

ff95f8d


          Alter tyescript and introcude the calculation fn

f1c81b1


          add test

8aa3252


          remove erroneous println

288b5b5

wirednkod requested review from pepoviola and l0r1s

May 17, 2023 22:12

pepoviola reviewed

View reviewed changes

crates/parser/src/ast.rs Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

crates/parser/src/lib.rs Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

crates/parser/src/lib.rs Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

crates/parser/src/zombienet.pest Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

examples/0001-small-network.zndsl Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

javascript/packages/orchestrator/src/test-runner/assertions.ts Outdated Show resolved Hide resolved

pepoviola reviewed

View reviewed changes

Collaborator

pepoviola left a comment

Looks good! A couple of comments to discuss.
Thanks!!

wirednkod added 7 commits

May 18, 2023 09:53


          rename metrics_calc to metrics_a and metrics_b

b5a4e21


          Address more comments

191b79f


          Add within in tests

2f4b2a5


          Merge branch 'main' into nik-substracting-metrics

6a097b6


          Add extra logic for nodes' groups

4a5881d


          Merge branch 'nik-substracting-metrics' of github.com:paritytech/zomb…

d6669b8

…ienet into nik-substracting-metrics


          Add extra example for node groups

11ca6c6

pepoviola approved these changes

View reviewed changes

Collaborator

pepoviola left a comment

Awesome, thanks!!

l0r1s reviewed

View reviewed changes

javascript/packages/orchestrator/src/test-runner/assertions.ts Outdated Show resolved Hide resolved


          Update javascript/packages/orchestrator/src/test-runner/assertions.ts

bf91eb6

Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>

wirednkod requested a review from l0r1s

May 18, 2023 18:56

l0r1s approved these changes

View reviewed changes

Contributor

l0r1s commented May 18, 2023

👍


          fix minor string literal missing

d02e43f

wirednkod merged commit f49e5f3 into main

wirednkod deleted the nik-substracting-metrics branch

May 19, 2023 10:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet