fix(test-runner): fix logic for equals 0 desired value and timeout #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0r1s
approved these changes
Oct 18, 2023
wirednkod
reviewed
Oct 18, 2023
| @@ -276,7 +276,7 @@ export class NetworkNode implements NetworkNodeInterface { | |||
| ]); | |||
| if (resp instanceof Error) { | |||
| // use `undefined` metrics values in `equal` comparisons as `0` | |||
| if (timedout && comparator === "equal" && desiredMetricValue === 0) | |||
| if (timedout && comparator === "equal" && desiredMetricValue === 0 && value === undefined) | |||
There was a problem hiding this comment.
I do not think that the desiredMetricValue should play any role on what its value is
Suggested change
| if (timedout && comparator === "equal" && desiredMetricValue === 0 && value === undefined) | |
| if (timedout && comparator === "equal" && value === undefined) |
There was a problem hiding this comment.
Yes, the edge case is only valid when the desired value is 0 because prometheus doesn't reports some metrics until they are incremented to 1 , that was the root of this workaround.
alexggh
approved these changes
Oct 18, 2023
wirednkod
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1426
cc @alexggh