Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Setup process #312

Merged
merged 10 commits into from
Aug 25, 2022
Merged

Create Setup process #312

merged 10 commits into from
Aug 25, 2022

Conversation

wirednkod
Copy link
Contributor

This PR creates an automated script that, setups locally the environment for running zombienet. Image below shows the outcome of the script:

image

User, once finishes with cloning and building the repo, can run the command node dist/setup.js -b <binaries>:
This will add the binaries that user wants to be downloaded, provided in a row without any separators; They are downloaded in 'dist' directory and appropriate executable permissions are assigned.
Possible options: polkadot, parachain. Example: node dist/setup.js -b polkadot parachain

AdderCollator also is a possible option but due to the fact that it exists only in gitlab as an artifact that seizes to exist after few days, it is not activated just yet

@wirednkod wirednkod marked this pull request as ready for review August 25, 2022 09:45
@wirednkod wirednkod added the documentation Improvements or additions to documentation label Aug 25, 2022
src/constants.ts Outdated
@@ -11,6 +11,14 @@ export const RPC_HTTP_PORT = 9944;
// The port substrate listens for p2p connections on
export const P2P_PORT = 30333;

// Paths for downloading the binaries for zombienet setup
export const DEFAULT_COMMAND_URL =
"https://github.com/paritytech/polkadot/releases/download/v0.9.27/polkadot";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wirednkod, I think we need to add the logic to download the latest release so we don't need to update this path every new release. For example v0.9.28 was release two days ago.

Copy link
Contributor Author

@wirednkod wirednkod Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not agree more. This was more of a first version, to see if we are on correct path.

src/constants.ts Outdated
export const DEFAULT_ADDER_COLLATOR_URL =
"https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1769497/artifacts/raw/artifacts/adder-collator";
export const DEFAULT_CUMULUS_COLLATOR_URL =
"https://github.com/paritytech/cumulus/releases/download/v0.9.230/polkadot-parachain";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Parachain URL we cannot really do that as the latest release may not contain the polkadot-parachain asset (see the latest one for example. I will make a change for the polkadot, but we will need probably, until somehow this is standardized, to adjust the polkadot-parachain manually for now

@pepoviola
Copy link
Collaborator

Hi @wirednkod, looks good!!! thanks! The only comment is try to get the latest version querying the github api if is possible.

Thanks!

Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 🙌🙌 Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants