-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the test results fit in a table with timestamps #423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some nip-ticks this looks good to me
The gitlab tests are failing due to the way that the link is added to the code. Im not sure how this could be solved cc @pepoviola |
Yes, we need to resolve the path and not use
Let me fix this. 👍 |
@wirednkod fixed :), can you review and merge if you approved. |
Thank you @pepoviola . I have requested 2 changes on this PR - once they are made I will merge. |
@wirednkod I think your changes request are addressed |
Awesome. Thank you @Gioyik for your contribution |
fixes #93