Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the test results fit in a table with timestamps #423

Merged
merged 10 commits into from
Oct 18, 2022
Merged

make the test results fit in a table with timestamps #423

merged 10 commits into from
Oct 18, 2022

Conversation

Gioyik
Copy link
Contributor

@Gioyik Gioyik commented Sep 26, 2022

fixes #93

Copy link
Contributor

@wirednkod wirednkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some nip-ticks this looks good to me

src/utils/tableReporter.ts Outdated Show resolved Hide resolved
@wirednkod wirednkod self-requested a review October 17, 2022 07:34
@wirednkod
Copy link
Contributor

wirednkod commented Oct 17, 2022

The gitlab tests are failing due to the way that the link is added to the code. Im not sure how this could be solved

cc @pepoviola

@pepoviola
Copy link
Collaborator

The gitlab tests are failing due to the way that the link is added to the code. Im not sure how this could be solved

cc @pepoviola

Yes, we need to resolve the path and not use mocha.reporter(process.cwd() + "/dist/utils/tableReporter");.

2022-10-17T07:05:38.506Z zombie-cli TypeError: Cannot find module '/home/nonroot/zombie-net/scripts/ci/1665990334/dist/utils/tableReporter'
Require stack:
- /home/nonroot/zombie-net/node_modules/mocha/lib/mocha.js
- /home/nonroot/zombie-net/node_modules/mocha/index.js
- /home/nonroot/zombie-net/dist/test-runner/index.js
- /home/nonroot/zombie-net/dist/cli.js

Let me fix this. 👍
Thanks!!

@pepoviola
Copy link
Collaborator

@wirednkod fixed :), can you review and merge if you approved.
@Gioyik thanks for your contribution!! 🙌

@wirednkod
Copy link
Contributor

@wirednkod fixed :), can you review and merge if you approved.

Thank you @pepoviola . I have requested 2 changes on this PR - once they are made I will merge.

@Gioyik
Copy link
Contributor Author

Gioyik commented Oct 18, 2022

@wirednkod I think your changes request are addressed

@wirednkod
Copy link
Contributor

Awesome. Thank you @Gioyik for your contribution

@mergify mergify bot merged commit 7562b27 into main Oct 18, 2022
@mergify mergify bot deleted the gio/93 branch October 18, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamps on test progress output
3 participants