Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paraNodes not being added to the logs dir #731

Merged
merged 3 commits into from
Feb 12, 2023
Merged

Fix paraNodes not being added to the logs dir #731

merged 3 commits into from
Feb 12, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 10, 2023

Closes #699

Small fix, logs were not dumped in logs directory because concat returns a new array instead of modifying memo.
Now artifact logs for collators should also show up in CI.

pepoviola
pepoviola approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!!

Can you run:

npm run lint:write

To lint the code, thanks!

@pepoviola pepoviola merged commit 7ff411e into paritytech:main Feb 12, 2023
@pepoviola
Copy link
Collaborator

thanks @skunert !! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Artifact logs do not contain collator logs
2 participants
@skunert @pepoviola