Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the multiaddress for bootnodes string #774

Merged
merged 3 commits into from
Mar 8, 2023
Merged

fix the multiaddress for bootnodes string #774

merged 3 commits into from
Mar 8, 2023

Conversation

pepoviola
Copy link
Collaborator

Fix the bootnode string to use same logic used to generate the --listen-add value.

cc @melekes

@pepoviola pepoviola requested a review from wirednkod March 8, 2023 11:53
wirednkod
wirednkod approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@wirednkod wirednkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor console removals

javascript/packages/orchestrator/src/bootnode.ts Outdated Show resolved Hide resolved
javascript/packages/orchestrator/src/orchestrator.ts Outdated Show resolved Hide resolved
@pepoviola pepoviola merged commit ceadebd into main Mar 8, 2023
@pepoviola pepoviola deleted the fix-multiaddress-bootnode branch March 8, 2023 13:24
@melekes
Copy link

melekes commented Mar 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepoviola @melekes @wirednkod