Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nix npmdepshash #853

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Bump nix npmdepshash #853

merged 4 commits into from
Mar 27, 2023

Conversation

rgoulter
Copy link
Contributor

@rgoulter rgoulter commented Mar 27, 2023

For the Nix stuff added in #772, following #808.

Each time the javascript/package-lock.json updates (and it has been updated since the last time flake-modules.nix was updated in #808), someone who likes nix should run something like:

nix run nixpkgs#prefetch-npm-deps -- javascript/package-lock.json 2>/dev/null
# update npmDepsHash with this value

to update the value of the npmDepsHash in the flake-module.nix.

cc @dzmitry-lahoda

@wirednkod
Copy link
Contributor

Thank you @rgoulter . I think it will be nice to add inside the documentation, (maybe at the setup page?) some information about nix, including the info added in this PR. What do you think?

@rgoulter
Copy link
Contributor Author

I think it will be nice to add inside the documentation, (maybe at the setup page?) some information about nix,

Right, it would be good to get #775 done.

I think the right place to add it is near the installation documentation. -- a command like nix run github:paritytech/zombienet is roughly equivalent to "download the latest build of zombienet and run that".

I'll send a PR with some documentation briefly explaining Nix, and a couple of useful ways of using it.

including the info added in this PR.

Ah, I see that the docs do have a "development" page.
https://paritytech.github.io/zombienet/development.html

Yes, I think it would be useful to add the same details I included in this PR in the "development documentation". Albeit, the prefetch command is already mentioned in flake-module.nix.

# this should be updated on each dependency change (use `prefetch-npm-deps` to get new hash)

@wirednkod
Copy link
Contributor

I'll send a PR with some documentation briefly explaining Nix, and a couple of useful ways of using it.

Thank you so much @rgoulter ! That would be great - and will close #775 as well. Feel free to add it as a "fixes #775" in that PR in order to close once merged

Copy link
Contributor

@wirednkod wirednkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comments concerning Documentation this looks good to me

@rgoulter rgoulter mentioned this pull request Mar 27, 2023
@pepoviola pepoviola merged commit 2e22830 into paritytech:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants