-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nix npmdepshash #853
Bump nix npmdepshash #853
Conversation
This is for the tsc in the cli workspace package.
Thank you @rgoulter . I think it will be nice to add inside the documentation, (maybe at the setup page?) some information about nix, including the info added in this PR. What do you think? |
Right, it would be good to get #775 done. I think the right place to add it is near the installation documentation. -- a command like I'll send a PR with some documentation briefly explaining Nix, and a couple of useful ways of using it.
Ah, I see that the docs do have a "development" page. Yes, I think it would be useful to add the same details I included in this PR in the "development documentation". Albeit, the prefetch command is already mentioned in Line 19 in d13975e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments concerning Documentation this looks good to me
For the Nix stuff added in #772, following #808.
Each time the
javascript/package-lock.json
updates (and it has been updated since the last time flake-modules.nix was updated in #808), someone who likes nix should run something like:to update the value of the
npmDepsHash
in theflake-module.nix
.cc @dzmitry-lahoda