refactor(cli): split cli in actions files

[pepoviola]

Split the cli in diff actions files.

[l0r1s]

Suggested change

	parachains &&
	parachains.forEach((parachain: any) => {
	collators = [];
	parachain.nodes.forEach((n: any) => {
	collators.push({
	name: n.name,
	command: "adder-collator",
	...DEFAULT_NODE_VALUES,
	});
	});
	paras.push({
	id: parachain.id,
	collators,
	});
	});
	paras = paras.concat(
	parachains.map(({ id, nodes }) => ({
	id,
	collators: (nodes || []).map(({ name }) => ({
	name,
	command: "adder-collator",
	...DEFAULT_NODE_VALUES,
	})),
	})),
	);

What do you think, using destructuring and functionnal programming ?

[pepoviola]

Sounds good 👍

[l0r1s]

Suggested change

	simpleParachains &&
	simpleParachains.forEach((sp: any) => {
	collators.push({
	name: sp.name,
	command: "adder-collator",
	...DEFAULT_NODE_VALUES,
	});
	paras.push({
	id: sp.id,
	collators,
	});
	});
	paras = paras.concat(
	simpleParachains.map(({ id, name }) => ({
	id,
	collators: [{ name, command: "adder-collator", ...DEFAULT_NODE_VALUES }],
	})),
	);

Destructuring and functionnal programming part 2

[l0r1s]

My question here is, because we don't reset the collators array in the old code, do we really want to have a parachain B to have the previous collator of parachain A ?

[pepoviola]

No, we don't want. This is a bug and the suggested code is ok.
Thanks!

[l0r1s]

If you use fs/promises instead of fs, you can simplify to:

Suggested change

	fs.writeFile(
	`${fullPath}/${fileName}-zombienet.json`,
	JSON.stringify(jsonOutput),
	(error: any) => {
	if (error) throw error;
	},
	);
	await fs.writeFile(
	`${fullPath}/${fileName}-zombienet.json`,
	JSON.stringify(jsonOutput)
	);

[pepoviola]

We should change the import to use fs.promises here.

[l0r1s]

Yes, the exact import is import {...} from "fs/promises

[l0r1s]

Have you heard about the colors library ?

It could enable to simplify the code like this (it extends the String.constructor):

Suggested change

	console.log(decorators.green("\n\n🧟🧟🧟 ZombieNet Setup 🧟🧟🧟\n\n"));
	console.log("\n\n🧟🧟🧟 ZombieNet Setup 🧟🧟🧟\n\n".green);

Simpler and better because we don't have to manage our own "colors" system in utils.

[pepoviola]

Yes, I remember to look at colors but I just went to make an small library for a few colors we use. We can iterate over this decision.
Thanks!

[wirednkod]

Have you heard about the colors library ?

It could enable to simplify the code like this (it extends the String.constructor):

Simpler and better because we don't have to manage our own "colors" system in utils.

I think we should reduce npm dependencies as much as possible

[wirednkod]

Have you heard about the colors library ?

It could enable to simplify the code like this (it extends the String.constructor):

Simpler and better because we don't have to manage our own "colors" system in utils.

I think we should reduce npm dependencies as much as possible