Add eslint and configuration #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
reviewed
Apr 3, 2023
|
Looks good! I think we need to order the prs since this one modify several files that are pending to merge in others prs. |
|
PR is not done yet. I prefer to merge this last, as it changes a HUGE amount of files (plus I need to add the log as discussed), so I would not worry at this point. Once it is done we can align on when to merge |
How about letting this PR with console log and setup the logger/console log rule in a new PR ? |
l0r1s
suggested changes
Apr 4, 2023
javascript/packages/orchestrator/src/providers/k8s/chain-spec.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/k8s/chain-spec.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/k8s/kubeClient.ts
Outdated
Show resolved
Hide resolved
l0r1s
reviewed
Apr 10, 2023
Comment on lines
347
to
576
| localFilePath: parachainSpecPath, | ||
| remoteFilePath: `${client.remoteDir}/${node.chain}-${paraId}.json`, | ||
| }); | ||
| parachainSpecId = await getChainIdFromSpec(parachainSpecPath); | ||
| } | ||
| for (const override of node.overrides) { | ||
| finalFilesToCopyToNode.push({ | ||
| localFilePath: override.local_path, | ||
| remoteFilePath: `${client.remoteDir}/${override.remote_name}`, | ||
| }); | ||
| } | ||
|
|
||
| let keystoreLocalDir; | ||
| if (node.accounts) { | ||
| // check if the node directory exists if not create (e.g for k8s provider) | ||
| let nodeFilesPath = tmpDir.path; | ||
| if (parachain && parachain.name) nodeFilesPath += `/${parachain.name}`; | ||
| nodeFilesPath += `/${node.name}`; | ||
|
|
||
| await makeDir(nodeFilesPath, true); | ||
|
|
||
| const isStatemint = parachain && parachain.chain?.includes("statemint"); | ||
| const keystoreFiles = await generateKeystoreFiles( | ||
| node, | ||
| nodeFilesPath, | ||
| isStatemint, | ||
| ); | ||
| keystoreLocalDir = path.dirname(keystoreFiles[0]); | ||
| } | ||
|
|
||
| // replace all network references in command | ||
| replaceNetworkRef(podDef, network); | ||
|
|
||
| await client.spawnFromDef( | ||
| podDef, | ||
| finalFilesToCopyToNode, | ||
| keystoreLocalDir, | ||
| parachainSpecId || client.chainId, | ||
| node.dbSnapshot, | ||
| ); | ||
|
|
||
| const [nodeIp, nodePort] = await client.getNodeInfo(podDef.metadata.name); | ||
| const nodeMultiAddress = await generateBootnodeString( | ||
| node.key!, | ||
| node.args, | ||
| nodeIp, | ||
| nodePort, | ||
| true, | ||
| node.p2pCertHash, | ||
| ); | ||
| multiAddressByNode[podDef.metadata.name] = nodeMultiAddress; | ||
|
|
||
| if (node.addToBootnodes) { | ||
| bootnodes.push(nodeMultiAddress); | ||
| await addBootNodes(chainSpecFullPath, bootnodes); | ||
| } | ||
|
|
||
| let networkNode: NetworkNode; | ||
|
|
||
| const endpointPort = RPC_WS_PORT; | ||
| if (options?.inCI) { | ||
| const nodeIp = await client.getNodeIP(podDef.metadata.name); | ||
| networkNode = new NetworkNode( | ||
| node.name, | ||
| WS_URI_PATTERN.replace("{{IP}}", nodeIp).replace( | ||
| "{{PORT}}", | ||
| endpointPort.toString(), | ||
| ), | ||
| METRICS_URI_PATTERN.replace("{{IP}}", nodeIp).replace( | ||
| "{{PORT}}", | ||
| PROMETHEUS_PORT.toString(), | ||
| ), | ||
| nodeMultiAddress, | ||
| userDefinedTypes, | ||
| ); | ||
| } else { | ||
| const nodeIdentifier = `${podDef.kind}/${podDef.metadata.name}`; | ||
| const fwdPort = await client.startPortForwarding( | ||
| endpointPort, | ||
| nodeIdentifier, | ||
| ); | ||
| const nodePrometheusPort = await client.startPortForwarding( | ||
| PROMETHEUS_PORT, | ||
| nodeIdentifier, | ||
| ); | ||
|
|
||
| const listeningIp = networkSpec.settings.local_ip || LOCALHOST; | ||
|
|
||
| networkNode = new NetworkNode( | ||
| node.name, | ||
| WS_URI_PATTERN.replace("{{IP}}", listeningIp).replace( | ||
| "{{PORT}}", | ||
| fwdPort.toString(), | ||
| ), | ||
| METRICS_URI_PATTERN.replace("{{IP}}", listeningIp).replace( | ||
| "{{PORT}}", | ||
| nodePrometheusPort.toString(), | ||
| ), | ||
| nodeMultiAddress, | ||
| userDefinedTypes, |
There was a problem hiding this comment.
🤔 Isnt this the code that @pepoviola moved to spawner through the PR #879 ?
There was a problem hiding this comment.
yes, is part of the spawner now.
pepoviola
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.