-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto/native resources #894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
reviewed
Apr 3, 2023
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Outdated
Show resolved
Hide resolved
pepoviola
reviewed
Apr 3, 2023
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Outdated
Show resolved
Hide resolved
pepoviola
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of styling suggestion/questions.
Thanks!!
wirednkod
reviewed
Apr 4, 2023
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/native/resources/node.resource.ts
Show resolved
Hide resolved
l0r1s
force-pushed
the
refacto/native-resources
branch
from
April 4, 2023 10:16
4b539c5
to
ea60645
Compare
wirednkod
approved these changes
Apr 4, 2023
pepoviola
approved these changes
Apr 4, 2023
l0r1s
force-pushed
the
refacto/native-resources
branch
from
April 5, 2023 15:19
d34d9bb
to
df00db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.