feat: refactored convert command logic to fix issues #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0r1s
force-pushed
the
feat/refacto-convert-command
branch
from
6d074c1
to
3254cbf
Compare
wirednkod
approved these changes
Apr 11, 2023
| const baseName = path.basename(filePath, extension); | ||
| let config; | ||
|
|
||
| console.log(extension); |
| const collator = { | ||
| name: "alice", | ||
| command: bin, | ||
| p2p_port: +port, |
There was a problem hiding this comment.
Suggested change
| p2p_port: +port, | |
| p2p_port: +port, |
nice usage of unary operator!
| parachains: ParachainConfig[]; | ||
| simpleParachains: SimpleParachainConfig[]; | ||
| hrmpChannels: HrmpChannelsConfig[]; | ||
| types: any; |
There was a problem hiding this comment.
This eventually will byte us in the ass; Maybe add a normal type if possible?
There was a problem hiding this comment.
Well, I have used the exact type used by the Polkadot Launch repo: https://github.com/paritytech/polkadot-launch/blob/master/src/types.d.ts to have maximum compatibility and minimum issues so I would prefer to keep it to avoid unwanted behavior in the future, wdyt ?
l0r1s
force-pushed
the
feat/refacto-convert-command
branch
from
3254cbf
to
746fc2d
Compare
pepoviola
approved these changes
Apr 12, 2023
|
Thanks @l0r1s ! |
This was referenced Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the convert command logic to take into accounts ports and missing values:
Input polkadot launch config:
{ "relaychain": { "bin": "../../polkadot/target/release/polkadot", "chain": "rococo-local", "nodes": [ { "name": "alice", "wsPort": 9944, "port": 30444, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "bob", "wsPort": 9955, "port": 30555, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "charlie", "wsPort": 9966, "port": 30666, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "dave", "wsPort": 9967, "port": 30667, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "ferdie", "wsPort": 9968, "port": 30668, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "eve", "wsPort": 9969, "port": 30669, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "one", "wsPort": 9970, "port": 30670, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] }, { "name": "two", "wsPort": 9971, "port": 30671, "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ] } ], "genesis": { "runtime": { "runtime_genesis_config": { "parachainsConfiguration": { "config": { "validation_upgrade_frequency": 1, "validation_upgrade_delay": 1 } } } } } }, "simpleParachains": [], "parachains": [ { "bin": "../../bifrost-node/target/release/bifrost-node", "id": "2001", "chain":"dev", "nodes": [ { "wsPort": 9995, "port": 31200, "name": "alice", "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ] } ] }, { "bin": "../../Acala/target/release/acala", "id": "2000", "chain": "karura-dev", "nodes": [ { "wsPort": 9999, "port": 31300, "name": "alice", "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ] } ] }, { "bin": "../../kylin-collator/target/release/kylin-collator", "id": "2102", "chain": "pichiu-local", "nodes": [ { "wsPort": 9991, "port": 31400, "name": "alice", "flags": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ] } ] } ], "hrmpChannels": [ { "sender": 2000, "recipient": 2001, "maxCapacity": 8, "maxMessageSize": 1024 }, { "sender": 2001, "recipient": 2000, "maxCapacity": 8, "maxMessageSize": 1024 }, { "sender": 2000, "recipient": 2102, "maxCapacity": 8, "maxMessageSize": 1024 }, { "sender": 2102, "recipient": 2000, "maxCapacity": 8, "maxMessageSize": 1024 }, { "sender": 2001, "recipient": 2102, "maxCapacity": 8, "maxMessageSize": 1024 }, { "sender": 2102, "recipient": 2001, "maxCapacity": 8, "maxMessageSize": 1024 } ], "types": {}, "finalization": false }Output zombienet config:
{ "relaychain": { "chain": "rococo-local", "default_command": "../../polkadot/target/release/polkadot", "genesis": { "runtime": { "runtime_genesis_config": { "parachainsConfiguration": { "config": { "validation_upgrade_frequency": 1, "validation_upgrade_delay": 1 } } } } }, "nodes": [ { "name": "alice", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9944, "p2p_port": 30444, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "bob", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9955, "p2p_port": 30555, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "charlie", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9966, "p2p_port": 30666, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "dave", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9967, "p2p_port": 30667, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "ferdie", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9968, "p2p_port": 30668, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "eve", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9969, "p2p_port": 30669, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "one", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9970, "p2p_port": 30670, "balance": 2000000000000, "validator": true, "invulnerable": true }, { "name": "two", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all" ], "ws_port": 9971, "p2p_port": 30671, "balance": 2000000000000, "validator": true, "invulnerable": true } ] }, "parachains": [ { "id": 2001, "chain": "dev", "collators": [ { "name": "alice", "command": "../../bifrost-node/target/release/bifrost-node", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ], "ws_port": 9995, "p2p_port": 31200, "balance": 2000000000000, "validator": true, "invulnerable": true } ] }, { "id": 2000, "chain": "karura-dev", "collators": [ { "name": "alice", "command": "../../Acala/target/release/acala", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ], "ws_port": 9999, "p2p_port": 31300, "balance": 2000000000000, "validator": true, "invulnerable": true } ] }, { "id": 2102, "chain": "pichiu-local", "collators": [ { "name": "alice", "command": "../../kylin-collator/target/release/kylin-collator", "args": [ "--unsafe-ws-external", "--unsafe-rpc-external", "--rpc-cors=all", "--", "--execution=wasm" ], "ws_port": 9991, "p2p_port": 31400, "balance": 2000000000000, "validator": true, "invulnerable": true } ] } ], "hrmp_channels": [ { "sender": 2000, "recipient": 2001, "max_capacity": 8, "max_message_size": 1024 }, { "sender": 2001, "recipient": 2000, "max_capacity": 8, "max_message_size": 1024 }, { "sender": 2000, "recipient": 2102, "max_capacity": 8, "max_message_size": 1024 }, { "sender": 2102, "recipient": 2000, "max_capacity": 8, "max_message_size": 1024 }, { "sender": 2001, "recipient": 2102, "max_capacity": 8, "max_message_size": 1024 }, { "sender": 2102, "recipient": 2001, "max_capacity": 8, "max_message_size": 1024 } ], "types": {} }