Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changed raw string zombie role to enum #938

Merged
merged 4 commits into from
Apr 18, 2023
Merged

chore: changed raw string zombie role to enum #938

merged 4 commits into from
Apr 18, 2023

Conversation

l0r1s
Copy link
Contributor

@l0r1s l0r1s commented Apr 17, 2023

Refacto for #901

pepoviola
pepoviola approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks, I think there are a couple of formating issues.

@wirednkod
Copy link
Contributor

Looks good! thanks, I think there are a couple of formating issues.

Looks good. I wonder why the PR got to open, since we have the hooks now 🤔

@l0r1s
Copy link
Contributor Author

l0r1s commented Apr 18, 2023

I added the missing "postinstall" script to make husky install automatic when you run "npm install"

@wirednkod
Copy link
Contributor

I added the missing "postinstall" script to make husky install automatic when you run "npm install"

You should not do that; Cause this way it will try (and fail) to run in gitlab;

@l0r1s
Copy link
Contributor Author

l0r1s commented Apr 18, 2023

Fixed following husky doc to avoid running in pipeline

@l0r1s l0r1s merged commit c48da13 into main Apr 18, 2023
@l0r1s l0r1s deleted the refacto/zombie-role-enum branch April 18, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l0r1s @wirednkod @pepoviola