Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added convert command to documentation #955

Merged
merged 3 commits into from
Apr 24, 2023
Merged

docs: added convert command to documentation #955

merged 3 commits into from
Apr 24, 2023

Conversation

l0r1s
Copy link
Contributor

@l0r1s l0r1s commented Apr 24, 2023

Resolves #782

wirednkod
wirednkod suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@wirednkod wirednkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polkadot launch is not the "old" project while Zombienet being the "new";
They are 2 different projects, with Polkadot Launch not being supported any more; As Parity we provide Zombienet as an alternative solution but not as the replacement;

docs/src/cli/convert.md Outdated Show resolved Hide resolved
pepoviola
pepoviola approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just @wirednkod comment about wording (old/new).
Thanks!

@l0r1s @wirednkod
chore: correct phrasing of convert description
5d780e9 
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
@l0r1s l0r1s requested a review from wirednkod April 24, 2023 15:21
@pepoviola pepoviola merged commit 2581aa8 into main Apr 24, 2023
@pepoviola pepoviola deleted the docs/convert branch April 24, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document convert command
3 participants
@l0r1s @pepoviola @wirednkod