fix dedup logs #977
Merged
fix dedup logs #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirednkod
approved these changes
Apr 29, 2023
l0r1s
reviewed
Apr 29, 2023
Comment on lines
+428
to
+429
| lastLogLineCheckedTimestamp, | ||
| lastLogLineCheckedIndex, |
There was a problem hiding this comment.
It won't cause issue if it's not initialized ?
| lastLogLineCheckedIndex: number, | ||
| ): string[] { | ||
| if (!lastLogLineCheckedTimestamp) return logs; | ||
| if (useIndex) return logs.slice(lastLogLineCheckedIndex); |
There was a problem hiding this comment.
Here, lastLogLineCheckedIndex is undefined when entering the above loop
There was a problem hiding this comment.
Well, those two variables work in tandem to represent the different providers features. The invariant here is that lastLogLineCheckedIndex will be undefined at the same time that lastLogLineCheckedTimestamp is undefinded, so the this if (https://github.com/paritytech/zombienet/pull/977/files#diff-fc4624d6bb61da0712b154b5018f73681adaf8edadb4236a0b5293ea915ef41eR549) cover this case.
I think there is room to improving here, but we can do it in a follow up pr.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
And our current CI.