Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/k8s service #983

Merged
merged 12 commits into from
May 2, 2023
Merged

Feat/k8s service #983

merged 12 commits into from
May 2, 2023

Conversation

l0r1s
Copy link
Contributor

@l0r1s l0r1s commented May 1, 2023 •
edited
Loading

  • Updated pod RestartPolicy with k8s provider to Always
  • Added one service per pod and updated node identifier to match this and use service
  • Fixed a bug with label on pod not using the actual zombie role

@l0r1s l0r1s mentioned this pull request May 1, 2023
Closed
@pepoviola
Copy link
Collaborator

Thanks @l0r1s, looks good. We should also update the WS_URI and PROMETHEUS_URI to the service name when is used in our ci (https://github.com/paritytech/zombienet/pull/983/files#diff-24b7795ec93992e92b59b879677a7a7e90adcdf07284b6910a165592b680dabfL124-L133).

Thanks!

l0r1s
l0r1s commented May 1, 2023
View reviewed changes
Copy link
Contributor Author

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pepoviola pepoviola merged commit 742bc76 into main May 2, 2023
@pepoviola pepoviola deleted the feat/k8s-service branch May 2, 2023 10:52
@pepoviola pepoviola mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@wirednkod wirednkod Awaiting requested review from wirednkod

@emamihe emamihe Awaiting requested review from emamihe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0r1s @pepoviola