Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose label selection parameters #32

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Expose label selection parameters #32

merged 2 commits into from
Oct 30, 2017

Conversation

SeanNaren
Copy link
Collaborator

These parameters have helped reduce computational complexity in our previous implementations. Exposing them allows us to play with the values!

@ryanleary
Copy link
Collaborator

ryanleary commented Oct 30, 2017 •
edited
Loading

LGTM. Any anecdata based recommendations for parameter values?

@ryanleary ryanleary merged commit 60dbbaf into parlance:master Oct 30, 2017
@SeanNaren
Copy link
Collaborator Author

SeanNaren commented Oct 30, 2017 •
edited
Loading

Currently figuring out that now (we had 6 before, verifying it works well with this decoder)

@SeanNaren SeanNaren deleted the label_params branch October 30, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanleary ryanleary Awaiting requested review from ryanleary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanNaren @ryanleary