MDL-15768 - further capability check in mod/data portfolio export

patkira · Aug 11, 2008 · adbf3cd · adbf3cd
1 parent 07028cd
commit adbf3cd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/mod/data/export.php b/mod/data/export.php
@@ -49,7 +49,7 @@
     $fields[]= data_get_field($fieldrecord, $data);
 }
 
-$mform = new mod_data_export_form('export.php?d='.$data->id, $fields);
+$mform = new mod_data_export_form('export.php?d='.$data->id, $fields, $cm);
 
 if($mform->is_cancelled()) {
     redirect('view.php?d='.$data->id);

diff --git a/mod/data/export_form.php b/mod/data/export_form.php
@@ -8,10 +8,13 @@
 
 class mod_data_export_form extends moodleform {
     var $_datafields = array();
+    var $_cm;
+
      // @param string $url: the url to post to
      // @param array $datafields: objects in this database
-    function mod_data_export_form($url, $datafields) {
+    function mod_data_export_form($url, $datafields, $cm) {
         $this->_datafields = $datafields;
+        $this->_cm = $cm;
         parent::moodleform($url);
     }
 
@@ -53,7 +56,7 @@ function definition() {
         }
         $this->add_checkbox_controller(1, null, null, 1);
         require_once($CFG->libdir . '/portfoliolib.php');
-        if (true) { // @todo penny replace with permissions check
+        if (has_capability('mod/data:exportallentries', get_context_instance(CONTEXT_MODULE, $this->_cm->id))) {
             if ($portfoliooptions = portfolio_instance_select(
                 portfolio_instances(),
                 call_user_func(array('data_portfolio_caller', 'supported_formats')),