Skip to content

Commit

Permalink
Check for the required cmake 3.10.0 on Windows in setup.py
Browse files Browse the repository at this point in the history
The CMakeLists.txt requires it, so we might as well update the checkin setup.py and fail there.
  • Loading branch information
patrikhuber committed May 28, 2019
1 parent c253197 commit 3dd69f7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def run(self):

if platform.system() == "Windows":
cmake_version = LooseVersion(re.search(r'version\s*([\d.]+)', out.decode()).group(1))
if cmake_version < '3.1.0':
raise RuntimeError("CMake >= 3.1.0 is required on Windows")
if cmake_version < '3.10.0':
raise RuntimeError("CMake >= 3.10.0 is required on Windows")

for ext in self.extensions:
self.build_extension(ext)
Expand Down

0 comments on commit 3dd69f7

Please sign in to comment.