Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"missing" EventEmitter props NodeVM inherits #150

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

kylegoetz
Copy link
Contributor

NodeVM extends EventEmitter, so has .on and .off methods.

If you do something like

const vm = new NodeVM({...});
vm.on(ev, handler);

TS will complain that NodeVM has no "on" property because the type definitions for vm2 lacks any indication that NodeVM inherits from EventEmitter. That's what this PR fixes.

@patriksimek patriksimek merged commit 5e5009a into patriksimek:master Aug 16, 2018
@patriksimek
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants