Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown next, Select next] - [add MenuToggle to props table] #8211

Closed
tlabaj opened this issue Oct 12, 2022 · 9 comments
Closed

[Dropdown next, Select next] - [add MenuToggle to props table] #8211

tlabaj opened this issue Oct 12, 2022 · 9 comments
Assignees
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Oct 12, 2022

Is this a new component or an extension of an existing one?
What is the existing component, if any?
MenuToggle is used in the examples. Add it to the prop tables so consumers can easily find the documentation.

@tlabaj tlabaj added good first issue Hacktoberfest 🎃 Feature end user feature that requires design to define this, i.e. changes or augments the user experience. needs triage labels Oct 12, 2022
@mcarrano mcarrano added this to the 2023.01 milestone Oct 28, 2022
@CodeDuchess
Copy link

@nicolethoen I would be happy to work this ticket. Thanks.

@CodeDuchess
Copy link

CodeDuchess commented Nov 18, 2022

@tlabaj Is this the correct file path for the edits? patternfly-docs > components > dropdown > react-next.js
It does not exactly match the table here so I am confused:
Screen Shot 2022-11-17 at 7 19 37 PM

@nicolethoen
Copy link
Contributor

@CodeDuchess
There is a propComponents array listed at the top of each component’s example markdown file. The components listed in that array are automagically included at the bottom of the component’s API docs on the website. So this issue just has you adding MenuToggle as an item in the propComponents array in the next/Dropdown and next/Select component docs.

@nicolethoen
Copy link
Contributor

@CodeDuchess
Copy link

Thanks, Nicole.

@CodeDuchess
Copy link

@nicolethoen I have made the edits to the files. I was looking for directions about how to open a PR. I typically work with GitLab and we open a MR using the following: git status git add -A git commit -m "message" git push I was looking for something similar to that in the PatternFly reference doc, but I did not find it. Please advise. Thanks.

@nicolethoen
Copy link
Contributor

I believe all those commands should work the same to open a PR in github, as well! After you push, your should be able to go to your fork in github and see a notification that says something like "x branch has new commits." along with a button to open a PR.

@stale
Copy link

stale bot commented Mar 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 15, 2023
@nicolethoen
Copy link
Contributor

This issue is being addressed in the v5 branch in the following PRs:
#8825
#8835

@tlabaj tlabaj removed this from the Prioritized Backlog milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants