-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): deprecated old and promoted Next #8835
feat(Dropdown): deprecated old and promoted Next #8835
Conversation
Preview: https://patternfly-react-pr-8835.surge.sh A11y report: https://patternfly-react-pr-8835-a11y.surge.sh |
a8c9023
to
888584c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one comment about a pre existing issue with one of the demos.
@@ -73,25 +75,25 @@ export class CardDemo extends React.Component { | |||
|
|||
render() { | |||
const dropdownItems = [ | |||
<DropdownItem key="link">Link</DropdownItem>, | |||
<DropdownItem key="action" component="button"> | |||
<DropdownItemDeprecated key="link">Link</DropdownItemDeprecated>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dropdown in the toolbar of the Card view demo is not working. That was preexisting to this PR though. probably broke with overflow PR work... We can open a follow up issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see whether it's something I can fix as part of the followup to updating usage of deprecated Dropdown to new Dropdown. If it's anything more involved I can open a separate follow up issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. thanks.
888584c
to
0a3507a
Compare
Your changes have been released in:
Thanks for your contribution! 🎉 |
As first step for moving to the new PF5/Dropdown component. See patternfly/patternfly-react#8835 and patternfly/patternfly-react#8868 Changes made by https://github.com/patternfly/pf-codemods
As first step for moving to the new PF5/Dropdown component. See patternfly/patternfly-react#8835 and patternfly/patternfly-react#8868 Changes made by https://github.com/patternfly/pf-codemods
Use the new PF/Dropdown and PF/MenuToggle instead. Related to patternfly/patternfly-react#8835 and others.
Use the new PF/Dropdown and PF/MenuToggle instead. Related to patternfly/patternfly-react#8835 and others.
What: Closes #8072
Created a followup for updating deprecated usage: #8839
Pages in the preview that would be affected by this PR.
Examples:
Demos:
Additional issues: