fix(dropdown): Delay setting focus on first item to prevent inadvertent scroll #11018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11018.surge.sh A11y report: https://patternfly-react-pr-11018-a11y.surge.sh |
| @@ -127,7 +127,7 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({ | |||
| 'li button:not(:disabled),li input:not(:disabled),li a:not([aria-disabled="true"])' | |||
| ); | |||
| firstElement && (firstElement as HTMLElement).focus(); | |||
| }, 0); | |||
| }, 10); | |||
There was a problem hiding this comment.
@tlabaj wdyt about using a (beta) prop for this timeout amount? Wondering just based on how this issue has come up several times if we can rely on a static timeout without the potential to have to slowly increase it if the issue comes up again.
It'd also be a very specific prop, though, and possibly one we wouldn't need if we refactor things and move to Floating UI/another popper alternative.
There was a problem hiding this comment.
Yes. we can do that as follow up.
tlabaj
approved these changes
Sep 18, 2024
thatblindgeye
approved these changes
Sep 18, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #10896
Description:
Add a slight delay before setting focus on the first dropdown item when
shouldFocusFirstItemOnOpenis set. This gives enough time for the popover to be shown in the correct location so the scrollable doesn't scroll to the invalid location.