Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Menu toggle): Remove pf-m-action modifier #11096

Merged
merged 4 commits into from
Oct 2, 2024
Merged

fix(Menu toggle): Remove pf-m-action modifier #11096

merged 4 commits into from
Oct 2, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Oct 1, 2024 •
edited
Loading

What: Closes #11095

This PR does the following:

  • bumps core versions to latest
  • Removed the SplitButtonOptions interface and prop since it is no longer needed because there is no longer a variant. Consumers will now pass items directly to splitButtonItems prop
  • update all demos that are impacted by new API

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 1, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-11096.surge.sh

A11y report: https://patternfly-react-pr-11096-a11y.surge.sh

mcoker
mcoker approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🎃TM!

edonehoo
edonehoo approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good!

dlabaj
dlabaj reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React code looks good to me.

kmcfaul
kmcfaul requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor example update to get it working, otherwise lgtm. Slider also looks like it's acting fine on the preview.

packages/react-core/src/components/MenuToggle/examples/MenuToggleSplitButtonAction.tsx Outdated Show resolved Hide resolved
@mcoker mcoker mentioned this pull request Oct 2, 2024
Open
@tlabaj tlabaj requested a review from kmcfaul October 2, 2024 12:15
evwilkin
evwilkin approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmcfaul kmcfaul merged commit fe6871c into patternfly:main Oct 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj left review comments

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@evwilkin evwilkin evwilkin approved these changes

@mcoker mcoker mcoker approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@edonehoo edonehoo edonehoo approved these changes

Assignees
No one assigned
Labels
content review css review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu toggle: pf-m-action modifier no longer needed
8 participants
@tlabaj @patternfly-build @dlabaj @wise-king-sullyman @evwilkin @mcoker @kmcfaul @edonehoo