Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popper): prevented forceUpdate from firing when not necessary #9088

Merged
merged 1 commit into from
May 15, 2023

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented May 9, 2023

What: Closes #9012

This should resolve the recent visual bug for now. Opened #9089 for investigating an alternate solution.

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 9, 2023

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing the behavior anymore. LGTM

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing the behavior the first time this composable advanced search menu is opened. Unless it's a different behavior?
Are there possibly a few things we might need to update in demos like this to make sure it's using your change correctly?

@tlabaj
Copy link
Contributor

tlabaj commented May 10, 2023

I am still seeing the behavior the first time this composable advanced search menu is opened. Unless it's a different behavior? Are there possibly a few things we might need to update in demos like this to make sure it's using your change correctly?

I believe that is a different issue. I will defer to @thatblindgeye.

@thatblindgeye
Copy link
Contributor Author

@nicolethoen @tlabaj it doesn't look like it's caused by the forceUpdate call. I added another conditional to only forceUpdate if popper.props.role === 'tooltip' (since that's really the only situation this forceUpdate is for I believe) and the issue still persisted on that search input demo.

@nicolethoen
Copy link
Contributor

@nicolethoen @tlabaj it doesn't look like it's caused by the forceUpdate call. I added another conditional to only forceUpdate if popper.props.role === 'tooltip' (since that's really the only situation this forceUpdate is for I believe) and the issue still persisted on that search input demo.

I opened an issue to investigate this 'flashing' behavior we are seeing in components/demos using popper.
#9119

@tlabaj tlabaj merged commit a08454d into patternfly:v5 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Popper/Dropdown - positioning of popper element is set incorrectly
5 participants