-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popper): prevented forceUpdate from firing when not necessary #9088
Conversation
Preview: https://patternfly-react-pr-9088.surge.sh A11y report: https://patternfly-react-pr-9088-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not seeing the behavior anymore. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still seeing the behavior the first time this composable advanced search menu is opened. Unless it's a different behavior?
Are there possibly a few things we might need to update in demos like this to make sure it's using your change correctly?
I believe that is a different issue. I will defer to @thatblindgeye. |
@nicolethoen @tlabaj it doesn't look like it's caused by the forceUpdate call. I added another conditional to only forceUpdate if |
I opened an issue to investigate this 'flashing' behavior we are seeing in components/demos using popper. |
What: Closes #9012
This should resolve the recent visual bug for now. Opened #9089 for investigating an alternate solution.
Additional issues: