chore: add "sideEffects": false to package.json
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `"sideEffects": false` to package.json for maximum tree-shakability. Without `"sideEffects"` switched off build systems aren't able to properly eliminate dead code (e.g. Next.js) and could still contain unused code, [like wordlists](wevm/viem#2069), even if they are unused. More info: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Sep 7, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@scure/bip39](https://paulmillr.com/) ([source](https://redirect.github.com/paulmillr/scure-bip39)) | [`^1.3.0` -> `^1.4.0`](https://renovatebot.com/diffs/npm/@scure%2fbip39/1.3.0/1.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>paulmillr/scure-bip39 (@​scure/bip39)</summary> ### [`v1.4.0`](https://redirect.github.com/paulmillr/scure-bip39/releases/tag/1.4.0) [Compare Source](https://redirect.github.com/paulmillr/scure-bip39/compare/1.3.0...1.4.0) - Bump noble-hashes to [v1.5.0](https://redirect.github.com/paulmillr/noble-hashes/releases/tag/1.5.0) - add `"sideEffects": false` to package.json by [@​tmm](https://redirect.github.com/tmm) in [paulmillr/scure-bip39#22 - Improve typescript compatibility by emitting separate types for cjs / esm #### New Contributors - [@​tmm](https://redirect.github.com/tmm) made their first contribution in [paulmillr/scure-bip39#22 **Full Changelog**: paulmillr/scure-bip39@1.3.0...1.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
"sideEffects": falseto package.json for maximum tree-shakability.Without
"sideEffects"switched off build systems aren't able to properly eliminate dead code (e.g. Next.js) and could still contain unused code, like wordlists, even if they are unused.More info: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free