Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Add precompiled binaries + composer install instructions #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Raruto
Copy link

@Raruto Raruto commented Feb 2, 2021

Similar to pauloamgomes/CockpitCMS-BetterSlugs#9, I have added:

  • alternative installation instructions (as proposed by piotr-cz)
  • precompiled fallback binaries for spatie optimizer (useful for quick installations on shared hosts)
  • some info about needed executables

Have a nice day,
Raruto

@pauloamgomes
Copy link
Owner

@Raruto I'm ok with the changes, but for security reasons I suggest to remove any binaries from the PR

@Raruto
Copy link
Author

Raruto commented Mar 27, 2021

Hi Paulo,

the main idea of this pull was to add a fallback for installations that don't / can't have the necessary files.
Anyway, if they are already installed on the system, native binaries are preferred (see actions.php for more info).

Let me know if you think there might be a smarter solution.

Have nice day,
Raruto

@pauloamgomes
Copy link
Owner

I understand, but binaries will not be included in the repo.

I prefer to have that clear as a dependency in the readme and maybe display a warning message (or in the system statys) in cockpit when the addon is being used that dependencies are missing

@Raruto
Copy link
Author

Raruto commented Apr 6, 2021

I've searched around a bit, but I can't find a simpler solution.

Without a package manager it is much more difficult to manage all the required dependencies and manually downloading them nullifies the advantage of using composer.

Someone uses another external repository dedicated only to binary files (or additional "user" variables, eg. a for custom BIN_PATH folder and the other options)

I have nothing against the latter solution, but in the end I think that for overall "ease of use" I would opt to use a dedicated fork (having another plugin dependent on "spatie" would seem overkill to me), anyway let me know if it could suit you, otherwise, I can also delete / restore the following portion: actions.php#R3-R72.


Useful links:

@pauloamgomes
Copy link
Owner

Thanks @Raruto !

I understand, but like said I prefer to not host any 3rd party binaries in the repo, updating the readme with instructions how to fetch them or adding a script to fetch them on demand its for me a valid solution.

@Raruto
Copy link
Author

Raruto commented Apr 8, 2021

We could use something like that: https://github.com/itgalaxy/bin-wrapper#usage
As for the binary files, those of imagemin are updated quite frequently.

I try to look better when I have little more time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants