Skip to content

Commit

Permalink
dist.cmake: add 'rebuild_cache' warning.
Browse files Browse the repository at this point in the history
dist.cmake is (for now) the only .cmake file that uses GIT_TAG at _cmake
configure time_. This means even "make clean" is not enough for
dist.cmake to take into account some git tag or version change. It's
very confusing because on the other hand "make check_version_h" and
everything else always shows up-to-date git information.

"make rebuild_cache" addresses this situation so mention it in a
warning.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
  • Loading branch information
marc-hb authored and lgirdwood committed Jul 10, 2020
1 parent 08c332c commit b70b13c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scripts/cmake/dist.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ add_custom_target(dist
COMMAND gzip -9 < "${TARBALL_PATH_TMP}" > "${TARBALL_PATH}"

WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}"
COMMENT "Creating tarball: ${TARBALL_PATH}"
COMMENT "Creating tarball: ${TARBALL_PATH}
Warning: you must invoke make/ninja 'rebuild_cache' when the version changes, 'clean' is not enough.
"
BYPRODUCTS "$TARBALL_VERSION_BINARY_PATH" "${TARBALL_PATH_TMP}" "${TARBALL_PATH}"
VERBATIM
USES_TERMINAL
Expand Down

0 comments on commit b70b13c

Please sign in to comment.