Update comment to reflect actual returned value #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For addresses that have more than 10K transactions etherscan.io actually returns the first transactions that are within the start and endblocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For addresses that have more than 10K transactions etherscan.io actually returns the first transactions that are within the start and end blocks.
If you compare the last block returned by the two links below you'll note that they are not the same, if the last 10k transactions were returned they would be the same as the end block is the same in both requests. The last block in first request that starts from block 0 is 5007989 while the last block in the second request that starts from block 5007989 is 5008401.
https://api.etherscan.io/api?module=account&action=txlist&address=0x6ddca767d731f57d90a516dd751f2aa9282b37d2&startblock=000&endblock=99999999&page=1&offset=10000&sort=asc&apikey=YourApiKeyToken
https://api.etherscan.io/api?module=account&action=txlist&address=0x6ddca767d731f57d90a516dd751f2aa9282b37d2&startblock=5007989&endblock=99999999&page=1&offset=10000&sort=asc&apikey=YourApiKeyToken
(Wanted to check the other cases where comments said last but didn't have time to find examples to determine if they also needed to be changed)