bbapply-embed boundary condition check #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdollar
added a commit
that referenced
this pull request
Feb 10, 2015
bbapply-embed boundary condition check (thanks Julieta!)
xzhewei
added a commit
to xzhewei/toolbox
that referenced
this pull request
Nov 21, 2017
Revert "Kaist"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line checks whether the embedded box will fit in the passed image, presumably to avoid runtime exceptions.
However, both
xandylocations are checked against the second dimension of the image, when I believeyshould be checked against the first dimension. This stopped the exceptions for me. Maybe issuing a warning that some boxes are not being painted would be useful.