Improves menu selection mechanics (regular vim) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Non-link items are skipped over when pressing j/k * First link is selected automatically when popup is opened
|
Solves the problem for me (Vim 8.2) – thanks @dsabsay! |
|
Works for me in vim 8.2.1750 as well and honestly makes the plug-in a 100% more useful. Would be great to get this merged. Thanks @dsabsay! |
|
Sorry for delay, thanks for work, but this doesn't work in this scenario:
I can't select [10 more] Also it's stop working on long lists (more then ~30 items)
Sorry for big delay, i think now i could do approvement without delays (1-2 days max) |
Merged
|
Also, cursor starting position fixed in #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #58. When opening the popup window, the cursor is now moved to the first link item in the list. Additionally, when
j/kare pressed, any non-link menu items are skipped over.I've implemented and tested with regular terminal vim 8.2. I'm not sure if Neovim had this problem or not.