Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metadata hash verification. #494

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Add support for metadata hash verification. #494

merged 4 commits into from
Sep 25, 2024

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented Sep 23, 2024

Context: Support for new Ledger App.

Closes [No ticket related, small change].

Following this guide, here we add the relevant code for the runtime to accept the verification of the metadata that was used for signing the extrinsic.

Note: the command to build the node for production now is cargo build --release --features metadata-hash.

It is important to note given that is not clear on the guide, that the environment variable required when building with this new feature (RUNTIME_METADATA_HASH) is set by the build script when the flag metadata-hash is used. See here.

@gianfra-t gianfra-t changed the title add frame metadata hash signed extra Add support for metadata hash verification. Sep 23, 2024
@gianfra-t gianfra-t requested a review from a team September 23, 2024 13:43
@gianfra-t
Copy link
Contributor Author

@pendulum-chain/devs I am not sure if this change will break existing integration of our services (and external ones), since now the runtime is expecting an extra byte that will flag if the sender of the extrinsic wants to verify the metadata or not (see flags here). I couldn't find this information on the Polkadot.js API, I would assume that by default this flag is set to not verify.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this change will break existing integration of our services (and external ones), since now the runtime is expecting an extra byte that will flag if the sender of the extrinsic wants to verify the metadata or not (see flags here).

Let's just see how it goes on Foucoco. I think we don't need to explicitly define it but if we do, we can just define it in pendulum.js and upgrade the dependencies that are using pendulum.js already. Then it should be included automatically.

Once this is merged we also need to change our Gitlab release pipeline to include the new --features metadata-hash flag by default. The pipeline will compile the wasm runtimes and put it into the Github releases after all.

runtime/pendulum/Cargo.toml Show resolved Hide resolved
@ebma ebma merged commit bb3543c into main Sep 25, 2024
1 of 2 checks passed
@ebma ebma deleted the add-metadata-hash branch September 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants