Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify DecimalsLookup trait to use it's own CurrencyId type #522

Closed
bogdanS98 opened this issue May 8, 2024 · 0 comments · Fixed by #523
Closed

Modify DecimalsLookup trait to use it's own CurrencyId type #522

bogdanS98 opened this issue May 8, 2024 · 0 comments · Fixed by #523
Assignees
@bogdanS98

Comments

@bogdanS98
Copy link
Contributor

bogdanS98 commented May 8, 2024 •
edited
Loading

Context

DecimalsLookup trait needs to reference it's own CurrencyId type instead of spacewalk_primitives::CurrencyId in the decimals function, so that it can be implemented by mocks which usually have the CurrencyId as a u64.

Requirement

Modify DecimalsLookup trait so that it uses it's own CurrencyId type.

Extra

Add PINK, HDX and vDOT tokens here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdanS98 bogdanS98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify DecimalsLookup trait, add PINK, HDX, vDOT to decimals list pendulum-chain/spacewalk
1 participant
@bogdanS98