Modify DecimalsLookup trait, add PINK, HDX, vDOT to decimals list #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
May 8, 2024
There was a problem hiding this comment.
Can you please run cargo +nightly-2024-02-09 fmt --all?
I had a similar problem in this action. We should probably change our pre-commit action somehow @b-yap
Besides that, can we please also add the decimals for the HDX token (XCM: 8, with 12 decimals) and already in anticipation of the vDOT token (probably XCM: 9, with 10 decimals) to the list?
ebma
approved these changes
May 8, 2024
bogdanS98
changed the title
bogdanS98
deleted the
522-modify-decimalslookup-trait-to-use-its-own-currencyid-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #522.