506 switch to stable rust toolchain channel

.github/workflows/ci-dev.yml

@@ -12,6 +12,7 @@ jobs:
       max-parallel: 1
       matrix:
         os: [ ubuntu-latest, macos-latest ]
+        rust: [stable, nightly]
         include:
           - os: ubuntu-latest
             sccache-path: /home/runner/.cache/sccache
@@ -54,9 +55,28 @@ jobs:
           brew install sccache             
 
       - name: Setup Rust toolchain
+        if: matrix.rust == 'stable'
         # Call `rustup show` as a hack so that the toolchain defined in rust-toolchain.toml is installed
         run: rustup show
 
+      - name: Remove rust-toolchain.toml for nightly
+        if: matrix.rust == 'nightly'
+        # To make sure that the nightly version will be used all throughout
+        run: |
+          rm /home/runner/work/spacewalk/spacewalk/rust-toolchain.toml
+
+      - name: Setup nightly Rust toolchain
+        if: matrix.rust == 'nightly'
+        uses:  dtolnay/rust-toolchain@nightly
+        with:
+          toolchain: nightly-2024-02-09
+          components: rustfmt, clippy
+          target: wasm32-unknown-unknown
+
+      - name: Setup nightly Rust as default
+        if: matrix.rust == 'nightly'
+        run: rustup default nightly-2024-02-09
+
       - name: Use Cache
         uses: Swatinem/rust-cache@v2
         with:
@@ -75,38 +95,39 @@ jobs:
       - name: Start sccache server
         run: sccache --start-server
 
-
       - name: Install Protoc
         uses: arduino/setup-protoc@v1
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Build
-        uses: actions-rs/cargo@v1
-        with:
-          command: build
-          args: --all-features
+      - name: Check Build
+        if: matrix.rust == 'stable'
+        run: |
+          bash ./scripts/cmd-all build check
 
       - name: Test
+        if: matrix.rust == 'nightly'
         uses: actions-rs/cargo@v1
-        env: 
+        env:
           SOURCE_STELLAR_SECRET_MAINNET: ${{ secrets.SOURCE_STELLAR_SECRET_MAINNET }}
           SOURCE_STELLAR_SECRET_TESTNET: ${{ secrets.SOURCE_STELLAR_SECRET_TESTNET }}
           DEST_STELLAR_SECRET_MAINNET: ${{ secrets.DEST_STELLAR_SECRET_MAINNET }}
           DEST_STELLAR_SECRET_TESTNET: ${{ secrets.DEST_STELLAR_SECRET_TESTNET }}
         with:
+          toolchain: nightly-2024-02-09
           command: test
           args: --all --all-features
 
       - name: Rustfmt
+        if: matrix.rust == 'nightly'
         uses: actions-rs/cargo@v1
         with:
+          toolchain: nightly-2024-02-09
           command: fmt
           args: --all -- --check
 
       - name: Print sccache stats
         run: sccache --show-stats
 
       - name: Stop sccache server
-        run: sccache --stop-server || true
-
+        run: sccache --stop-server || true

.github/workflows/ci-main.yml

@@ -6,6 +6,10 @@ on:
 name: continuous-integration-main
 jobs:
   ci:
+    strategy:
+      max-parallel: 1
+      matrix:
+        rust: [stable, nightly]
     runs-on: ubuntu-20.04
     env:
       RUST_BACKTRACE: full
@@ -36,10 +40,29 @@ jobs:
           sudo apt-get update && sudo apt-get upgrade -y
           sudo apt-get install -y protobuf-compiler libprotobuf-dev
 
-      - name: Setup Rust toolchain
+      - name: Setup stable Rust toolchain
+        if: matrix.rust == 'stable'
         # Call `rustup show` as a hack so that the toolchain defined in rust-toolchain.toml is installed
         run: rustup show
 
+      - name: Remove rust-toolchain.toml for nightly
+        if: matrix.rust == 'nightly'
+        # To make sure that the nightly version will be used all throughout
+        run: |
+          rm /home/runner/work/spacewalk/spacewalk/rust-toolchain.toml
+
+      - name: Setup nightly Rust toolchain
+        if: matrix.rust == 'nightly'
+        uses:  dtolnay/rust-toolchain@nightly
+        with:
+          toolchain: nightly-2024-02-09
+          components: rustfmt, clippy
+          target: wasm32-unknown-unknown
+
+      - name: Setup nightly Rust as default
+        if: matrix.rust == 'nightly'
+        run: rustup default nightly-2024-02-09
+
       - name: Use Cache
         uses: Swatinem/rust-cache@v2
         with:
@@ -52,38 +75,41 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Build
-        uses: actions-rs/cargo@v1
-        with:
-          command: build
-          args: --all-features
+      - name: Check Build
+        if: matrix.rust == 'stable'
+        run: |
+          bash ./scripts/cmd-all build check
 
       - name: Test
+        if: matrix.rust == 'nightly'
         uses: actions-rs/cargo@v1
-        env: 
+        env:
           SOURCE_STELLAR_SECRET_MAINNET: ${{ secrets.SOURCE_STELLAR_SECRET_MAINNET }}
           SOURCE_STELLAR_SECRET_TESTNET: ${{ secrets.SOURCE_STELLAR_SECRET_TESTNET }}
           DEST_STELLAR_SECRET_MAINNET: ${{ secrets.DEST_STELLAR_SECRET_MAINNET }}
           DEST_STELLAR_SECRET_TESTNET: ${{ secrets.DEST_STELLAR_SECRET_TESTNET }}
         with:
+          toolchain: nightly-2024-02-09
           command: test
           args: --all --all-features
 
       - name: Rustfmt
+        if: matrix.rust == 'nightly'
         uses: actions-rs/cargo@v1
         with:
+          toolchain: nightly-2024-02-09
           command: fmt
           args: --all -- --check
 
-      - name: Clippy -- Main
-        uses: actions-rs/cargo@v1
-        with:
-          command: clippy
-          args: --all-features -- -W clippy::all -A clippy::style -A clippy::forget_copy -A clippy::forget_ref
+      - name: Clippy -- Libraries and Binaries
+        if: matrix.rust == 'stable'
+        run: |
+          bash ./scripts/cmd-all clippy "clippy --lib --bins" "-- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references"           
 
-      - name: Clippy -- All Targets
+      - name: Clippy -- Tests and Examples
+        if: matrix.rust == 'nightly'
         uses: actions-rs/cargo@v1
         with:
+          toolchain: nightly-2024-02-09
           command: clippy
-          # We are a bit more forgiving when it comes to the code in tests and only check for correctness
-          args: --all-features --all-targets -- -A clippy::all -W clippy::correctness -A clippy::forget_copy -A clippy::forget_ref
+          args: --all-features --tests --benches --examples -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references