build(experimental): replace node-canvas with @napi-rs/canvas
#1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying penrose with
|
| Latest commit: |
b63fb11
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e53ea258.penrose-72l.pages.dev |
| Branch Preview URL: | https://canvas.penrose-72l.pages.dev |
wodeni
changed the title
node-canvas with @napi-rs/canvasnode-canvas with @napi-rs/canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an experiment to replace
node-canvaswith an alternative.node-canvasrequires native dependencies and specific Python versions to install, bloating the setup experience for Penrose contributors.The candidates are:
@napi-rs/canvas: currently tested on this branch.measureTextreturning errors due to missingtextBaseline, possibly related to Variable fonts Brooooooklyn/canvas#495.canvaskit-wasm: not tested. https://www.npmjs.com/package/canvaskit-wasm says...which is not promising
Implementation strategy and design decisions
Include a high-level summary of the implementation strategy and list important design decisions made, if any.
Examples with steps to reproduce them
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: