Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also export types for node next module resolution #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 2, 2024

When using node next / node16 module resolution (exports field), then Typescript will no longer check types field in package json but use types from the exports field that is currently being used.

When using node next / node16 module resolution (`exports` field),
then Typescript will no longer check `types` field in package json but
use `types` from the `exports` field that is currently being used.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Owner

@perry-mitchell perry-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@perry-mitchell
Copy link
Owner

Not sure why the tests are failing. I'll check it a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants