identify root certificate identification by equal subject and issuer #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tical in spite of defined authority key id.
pete911
approved these changes
May 20, 2023
|
Hi @jonhadfield, you are right, I realised this sometime ago when going through RFC, but completely forgot to fix it. Thanks again for the fix. I will do new release shortly as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The existing code asserts a certificate is a root by lack of authority key id although the rfc states:
This PR adds to the root check by first checking if the Subject and Issuer match, which should only be true if it is a root.
I first noticed this issue when running certinfo against a DigiCert root and it was identified as an intermediate. I've added the same root as test data and included a test that requires its now identified as a root.