Add support for signed commits #3055
Conversation
|
Thank you for contributing this feature! Your timing is impeccable. I was just talking with a colleague today about needing this feature! If I understand correctly, this only works for app-generated tokens, correct? I wonder what happens if you try to sign with a PAT. I guess the default |
|
I tried to make changes directly to your branch, but I don't have permission it seems. I'll merge to a feature branch before merging to |
|
Thank you for picking up this PR so quickly and for improving. Looking forward to seeing this feature in a new release soon! |
|
There's quite a bit of work to do before I can release this, but your contribution is a great start. Thank you! Working on it here: |
|
Ah I see... Yes, that looks like a lot of work really! Just passing all the test cases itself would have been quite challenging for me. Thank you very much for continuing to maintain this very useful Github Action and for continuing to add features. |
* Add support for signed commits (#3055) * formatting * fix eslint and lint errors * shift setting the base to before the push * sign commits by default for testing * add debug lines * read to buffer not string and use non-legacy method to base64 * debug payload without contents * disable linter for debug code * fix filepath when using path input * try to fix head repo * remove commented code * Try refactor of file changes * add tests for building file changes * add build file changes test for binary files * refactor graphql code into github helper class * build file changes even when there is no diff * add function to get commit detail * fix format * build branch commits * use source mode for deleted files * try rest api route * fix check for branch existence * force push * try fix base tree * debug commit verification * debug commit verification * fix format and cleanup * add executable mode file to test * limit blob creation concurrency * only build commits when feature enabled * remove unused code * update readme link * update docs for commit signing * fix capital letter * update docs * add throttling * set default back to false * output head sha and verified status * log outputs * fix head sha output * default the operation output to none * output retryafter for secondary rate limit * use separate client for branch and pull operations * add maintainer-can-modify input * rename git-token to branch-token * fix branch token input * remove deprecated env output * update docs * fix doc * update docs * build branch commits when there is a diff with the base * check verification status of head commit when not known * fix verified output when no commit signing is being used * draft always-true * convert to draft on branch updates when there is a diff with base * update docs with blob size limit * catch errors during blob creation for debugging * parse empty commits * pass base commit to push signed commits * use parent commit details in create commit * use parent tree for base_tree * multipart tree creation * update docs * update readme about the permissions of the default token * fix edge case where changes are partially merged * add updating documentation * fix typo * update major version --------- Co-authored-by: Ravi <1299606+rustycl0ck@users.noreply.github.com>
Add support for automatically signing the commits as
github-actionsbot. This is useful in cases where repo/org owners have enforced a signed-commit policy. If a custom github-token is provided for another Github App, then the commit will be signed as that app.This PR is related to or addresses the following issues:
I am a newbie with Typescript, so I have not separated out the logic to a different file or broken it into smaller functions/utilities. I might be able to spend a little bit more time on it to implement suggestions, but if it requires major refactoring, then please feel free to refactor and push the commits directly (or can also merge this PR and then refactor separately in a new PR).