Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version to 1.21, update Dockerfile alpine base image to 3.18 #447

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Update Go version to 1.21, update Dockerfile alpine base image to 3.18 #447

merged 3 commits into from
Aug 12, 2023

Conversation

lfittl
Copy link
Member

@lfittl lfittl commented Aug 11, 2023 •
edited
Loading 

Update Go version in use for packages and tests to 1.21

Additionally, this bumps up the minimum Go version to 1.20, and uses
that on Heroku, as Heroku's Go buildpack does not yet support 1.21.

Dockerfile: Update alpine base image from 3.15 to 3.18

Update Go download location from "golang.org" to "go.dev" domain

This has been changed upstream, and it seems reasonable to match.

@lfittl lfittl requested a review from a team August 11, 2023 22:21
msepga
msepga approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@msepga msepga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I noticed we set the minimum go version to 1.20 instead of 1.21 in go.mod - I'm assuming this is intentional, dropping a comment just in case it was a typo

go.mod
@@ -1,4 +1,4 @@
// +heroku goVersion go1.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be 21?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its intentional, since Heroku doesn't support 1.21 yet (heroku/heroku-buildpack-go#521)

@lfittl
Update Go version in use for packages and tests to 1.21
e63458b 
Additionally, this bumps up the minimum Go version to 1.20, and uses
that on Heroku, as Heroku's Go buildpack does not yet support 1.21.
@lfittl
Dockerfile: Update alpine base image from 3.15 to 3.18
9971327
@lfittl
Update Go download location from "golang.org" to "go.dev" domain
a90f689 
This has been changed upstream, and it seems reasonable to match.
@lfittl lfittl merged commit 767c896 into main Aug 12, 2023
4 checks passed
@lfittl lfittl deleted the update-go-version branch August 12, 2023 07:17
@seanlinsley seanlinsley mentioned this pull request Sep 29, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msepga msepga msepga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfittl @msepga