Fix: webpack config for plugins (katspaugh#2954)

* Fix: webpack config for plugins * UMD tests * Beta 12
phill2mj · Jul 1, 2023 · 260cec9 · 260cec9
1 parent 5df281b
commit 260cec9
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 5 deletions.
diff --git a/cypress/e2e/basic.cy.js b/cypress/e2e/basic.cy.js
@@ -1,4 +1,4 @@
-describe('WaveSurfer', () => {
+describe('WaveSurfer basic tests', () => {
   beforeEach((done) => {
     cy.visit('cypress/e2e/index.html')
 

diff --git a/cypress/e2e/options.cy.js b/cypress/e2e/options.cy.js
@@ -1,6 +1,6 @@
 const id = '#waveform'
 
-describe('WaveSurfer', () => {
+describe('WaveSurfer options tests', () => {
   beforeEach(() => {
     cy.visit('cypress/e2e/index.html')
 

diff --git a/cypress/e2e/regions.cy.js b/cypress/e2e/regions.cy.js
@@ -1,4 +1,4 @@
-describe('WaveSurfer plugins', () => {
+describe('WaveSurfer Regions plugin tests', () => {
   beforeEach((done) => {
     cy.visit('cypress/e2e/index.html')
 

diff --git a/cypress/e2e/umd.cy.js b/cypress/e2e/umd.cy.js
@@ -0,0 +1,20 @@
+describe('WaveSurfer UMD module tests', () => {
+  beforeEach(() => {
+    cy.visit('cypress/e2e/umd.html')
+    cy.window().its('WaveSurfer').should('exist')
+  })
+
+  it('should instantiate WaveSurfer with two plugins', () => {
+    cy.window().then((win) => {
+      return new Promise((resolve) => {
+        const { WaveSurfer } = win
+        win.wavesurfer = win.WaveSurfer.create({
+          container: '#waveform',
+          url: '../../examples/audio/demo.wav',
+          plugins: [WaveSurfer.Regions.create(), WaveSurfer.Timeline.create()],
+        })
+        resolve()
+      })
+    })
+  })
+})
diff --git a/cypress/e2e/umd.html b/cypress/e2e/umd.html
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>WaveSurfer CommonJS Test</title>
+
+    <script type="text/javascript" src="../../dist/wavesurfer.min.cjs"></script>
+    <script type="text/javascript" src="../../dist/plugins/regions.min.cjs"></script>
+    <script type="text/javascript" src="../../dist/plugins/timeline.min.cjs"></script>
+  </head>
+  <body>
+    <div id="waveform" style="width: 600px"></div>
+  </body>
+</html>
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wavesurfer.js",
-  "version": "7.0.0-beta.11",
+  "version": "7.0.0-beta.12",
   "license": "BSD-3-Clause",
   "author": "katspaugh",
   "description": "Navigable audio waveform player",

diff --git a/webpack.config.plugins.js b/webpack.config.plugins.js
@@ -14,7 +14,7 @@ export default {
   },
 
   output: {
-    globalObject: 'WaveSurfer',
+    globalObject: `typeof WaveSurfer !== 'undefined' ? WaveSurfer : this`,
     library: '[name]',
     libraryTarget: 'umd',
     libraryExport: 'default',