Merge pull request Carthage#2140 from Carthage/binaryproject-file-scheme

[BinaryProject] Add `file` scheme support
phimage · Sep 1, 2017 · e2af187 · e2af187
2 parents 708ca93 + 6d3d619
commit e2af187
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/Source/CarthageKit/BinaryProject.swift b/Source/CarthageKit/BinaryProject.swift
@@ -30,7 +30,7 @@ public struct BinaryProject {
 					guard let binaryURL = URL(string: value) else {
 						return .failure(BinaryJSONError.invalidURL(value))
 					}
-					guard binaryURL.scheme == "https" else {
+					guard binaryURL.scheme == "file" || binaryURL.scheme == "https" else {
 						return .failure(BinaryJSONError.nonHTTPSURL(binaryURL))
 					}
 

diff --git a/Tests/CarthageKitTests/BinaryProjectSpec.swift b/Tests/CarthageKitTests/BinaryProjectSpec.swift
@@ -74,6 +74,17 @@ class BinaryProjectSpec: QuickSpec {
 
 				expect(actualError) == .nonHTTPSURL(URL(string: "http://my.domain.com/framework.zip")!)
 			}
+
+			it("should parse with a file url") {
+				let jsonData = "{ \"1.0\": \"file:///my/domain/com/framework.zip\" }".data(using: .utf8)!
+				let actualBinaryProject = BinaryProject.from(jsonData: jsonData).value
+
+				let expectedBinaryProject = BinaryProject(versions: [
+					PinnedVersion("1.0"): URL(string: "file:///my/domain/com/framework.zip")!,
+				])
+
+				expect(actualBinaryProject) == expectedBinaryProject
+			}
 		}
 	}
 }