[DO NOT MERGE]PIC

[badochov]

Description

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[github-actions]

Unit Test Results

6 410 tests  +1 211   5 776 ✅ +1 123   30m 52s ⏱️ + 2m 53s
  354 suites +   56     634 💤 +   89 
    1 files   ±    0       0 ❌  -     1 

Results for commit ffe08e5. ± Comparison against base commit 9d138b9.

♻️ This comment has been updated with latest results.

[agkaminski]

Perhaps it might be better to make these TLS code files directly as asm (.S) files?

[badochov]

Perhaps it might be better to make these TLS code files directly as asm (.S) files?

Yeah, I think it's justified in this case

[badochov]

@astalke could you have a look at my changes to ia32 asm?

[astalke]

@astalke could you have a look at my changes to ia32 asm?

I've skimmed through code and I think it looks fine. I'm only concerned about cmove, because I am not sure if it is available in every version of CPU we support.

[kemonats]

Simple example:

int foo(int a, int b)
{
    return (a > 3) ? 4 : b;
}

-march=i586 ( as it is compiled target i386 ) without cmov

00000000 <foo>:
   0:   83 7c 24 04 03          cmpl   $0x3,0x4(%esp)
   5:   8b 44 24 08             mov    0x8(%esp),%eax
   9:   7f 05                   jg     10 <foo+0x10>
   b:   c3                      ret
   c:   8d 74 26 00             lea    0x0(%esi,%eiz,1),%esi
  10:   b8 04 00 00 00          mov    $0x4,%eax
  15:   c3                      ret

-march=i686

00000000 <foo>:
   0:   83 7c 24 04 03          cmpl   $0x3,0x4(%esp)
   5:   b8 04 00 00 00          mov    $0x4,%eax
   a:   0f 4e 44 24 08          cmovle 0x8(%esp),%eax
   f:   c3                      ret